feat(miniscript): add descriptor type detection and custom error #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces JsError with WasmMiniscriptError. This allows writing tests for funcs that return `Result<_, WasmMiniscriptError>`. Previously it was a pain because `JsError` did not implement Debug. Issue: BTC-1826
Add fromStringDetectType() that auto-detects whether a descriptor contains wildcards. If it does, returns a derivable descriptor, otherwise a definite one. Issue: BTC-1826
OttoAllmendinger
force-pushed
the
BTC-1826.add-fromStringDetectType
branch
from
f9a0423 to
1de8e99
Compare
davidkaplanbitgo
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fromStringDetectType() to auto-detect wildcards in descriptors. Replace
JsError with WasmMiniscriptError for better test ergonomics.
Issue: BTC-1826