Add silent payments address type to Glossary > Address page #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new section to the Glossary > Address page detailing the silent payments address type and its unique properties.
- Introduces the "Silent payments address" section
- Explains how silent payments addresses differ from other address types and their UX benefits
Contributor
|
Nice addition. Copilot had some recommendations to improve clarity and writing style. Up to you whether you want to adopt some of that. 
|
swedishfrenchpress
previously approved these changes
Jun 5, 2025
Collaborator
swedishfrenchpress
left a comment
swedishfrenchpress
left a comment
There was a problem hiding this comment.
ACK. Good addition.
....instead of "silent payments address"
removed repetitive verbiage; added explanation of improved UX while keeping length the same
Contributor
Author
Incorporated in c946524 |
swedishfrenchpress
approved these changes
Jun 7, 2025
Contributor
|
ACK. Let's get this live. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1151
🔎 Preview here 👀