Skip to content

Conversation

Bosch-0
Copy link
Collaborator

@Bosch-0 Bosch-0 commented Feb 7, 2022

Someone had to do it. Removed any reference to the distinction also.

Preview

Closes #635

Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this one one. There are several places we need to keep bitcoin capitalized:

  • In names like "Bitcoin Design Community" and "Partially Signed Bitcoin Transaction"
  • Beginning of sentences
  • URLS from third-party services (https://github.com/BitcoinDesign), as this might break them

Talk to @Bosch-0 and he gave me permission to push updates to address some of this.

I also think we should keep the section at the top of the Tech Primer, but change its focus from capitalization to just pointing out that bitcoin can refer to the network and/or the currency.

@GBKS GBKS added the Copy Task is about improving text. label Feb 7, 2022
GBKS
GBKS previously approved these changes Feb 7, 2022
@GBKS
Copy link
Contributor

GBKS commented Feb 7, 2022

ACK. Reviewed and also pushed a bunch of tweaks as I mentioned in my last comment.

As this touches a ton of files and it's easy to miss things, it would be helpful for another person to thoroughly review this PR.

@danielnordh
Copy link
Contributor

I just went through pretty much every file on the site manually in the browser and only found one leftover case where it was B and should have been b. Great work! Will approve and merge.

Copy link
Contributor

@danielnordh danielnordh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielnordh danielnordh merged commit ff3a289 into BitcoinDesign:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt lower case b for bitcoin

3 participants