-
Notifications
You must be signed in to change notification settings - Fork 114
Lowercased all the bitcoins! #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this one one. There are several places we need to keep bitcoin capitalized:
- In names like "Bitcoin Design Community" and "Partially Signed Bitcoin Transaction"
- Beginning of sentences
- URLS from third-party services (https://github.com/BitcoinDesign), as this might break them
Talk to @Bosch-0 and he gave me permission to push updates to address some of this.
I also think we should keep the section at the top of the Tech Primer, but change its focus from capitalization to just pointing out that bitcoin can refer to the network and/or the currency.
- Names like "Partially Signed Bitcoin Transaction" and "Bitcoin Design Guide" - Beginnings of sentences - URLs
ACK. Reviewed and also pushed a bunch of tweaks as I mentioned in my last comment. As this touches a ton of files and it's easy to miss things, it would be helpful for another person to thoroughly review this PR. |
I just went through pretty much every file on the site manually in the browser and only found one leftover case where it was B and should have been b. Great work! Will approve and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Someone had to do it. Removed any reference to the distinction also.
Preview
Closes #635