Discord #996
Discord #996
Conversation
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
|
||
| - name: Bitcoin Design Sprints | ||
| description: Improving lightning network wallets through applying the design guide, design thinking and problem solving. | ||
| description: This project from 2022 was about improving lightning network wallets through applying the design guide, design thinking and problem solving. |
There was a problem hiding this comment.
just emphasis to point to the archive?
There was a problem hiding this comment.
I don't understand the question. My rationale here was that it sounds like it's an ongoing project, when it's really gone inactive.
There was a problem hiding this comment.
Generally, we need to revise that page with more up-to-date projects. Something on my to-do list.
There was a problem hiding this comment.
I would ignore trying to update this as out of scope for this PR.
2022 wasn't that long ago and who knows if it will forever stay inactive.
DanGould
left a comment
DanGould
left a comment
There was a problem hiding this comment.
Love to see it!
Found a couple of small issues.
|
tACK. Tested clicking the button on mobile. |
|
I saw people talking about expiring Discord links on Slack in the latest Spiral post. @sbddesign when you created the link used in this PR, did you edit link settings to "never expire" and "no limit to number of uses"? |
Yes, I did use a never expires link |
Co-authored-by: Dan Gould <d@ngould.dev>
Co-authored-by: Dan Gould <d@ngould.dev>
|
Ok, I pushed some more updates. Ready for another review! |
|
Fixed the social metadata in the config file back to the way it was, and cleaned up some stuff. Ready for review again. |
danielnordh
left a comment
danielnordh
left a comment
There was a problem hiding this comment.
LGTM
Super minor, I would ignore trying to update the state of projects on the projects.md page and leave that for another PR.
Other than that it's good to go in my view and should be merged a.s.a.p
|
Thanks @danielnordh. I have one minor update already in here, just changing the sentence about Bitcoin Design Sprints. Ok to leave that minor change in this PR? I agree that we should make any further changes to updating content in another PR. If you're fine with it as is, can you leave an approval? Same with @Bosch-0 and @DanGould if you're fine with the latest updates I pushed. |
| links: | ||
| github: bitcoindesign | ||
| slack: bitcoindesign | ||
| discord: bitcoindesign |
There was a problem hiding this comment.
So we have the user/server names http://bitcoindesign.slack.com and https://github.com/bitcoindesign, but is there an equivalent like http://bitcoindesign.discord.com? As far as I know there are no unique server "usernames". If you know that this exists, we can keep it. Otherwise, let's remove this line.
There was a problem hiding this comment.
it'd be good to call these "subdomains" instead of "links," or hmm I'm not sure maybe a comment with the examples here
I asked Stephen what they were earlier in review but the answer wasn't clear. Glad you know!
There was a problem hiding this comment.
@GBKS No, I don't think we have a unique subdomain for our Discord instance. Not sure it's even possible.
I'm not entirely clear how that SEO jekyll tag actually maps those domains or whatever from the simple data in that JSON. I'm fine if you want to PR it out of there.
There was a problem hiding this comment.
Did a bit more Googleroni, and apparently search engines ignore this, and it should be an Array of URLs. So maybe we just delete it.
Yeah, it's fine. |
This PR would change the website to steer new contributors to Discord instead of Slack. For context, please read this document.
Discussion around this has been happening here: https://bitcoindesign.slack.com/archives/C014J9ZKXB4/p1678717074184419
💻 Deploy Preview