feat(agent): add "Copy" and "Redo" actions to assistant chat bubbles with improved timeline handling

Author: iptoux

CHANGELOG.md

@@ -33,13 +33,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - **Subagent tool inventory in prompt**: subagent system prompt now lists the actually-provisioned tools grouped by purpose (Workspace, Diffs, Git, Memory, Plans, Tasks, Rules & Skills, Web) — generated from `registry_filtered` so the prompt cannot drift from the schema. Adds an explicit anti-hallucination clause directing the subagent to attempt `list_workspace_files` / `read_workspace_file` before claiming a lack of tools. Stops weaker models from instantly returning `blocked`.
 - **Timeline tool-call compaction**: consecutive identical tool calls in the chat timeline collapse into a single row with a live `×N` counter badge that grows as new calls stream in. Expand chevron reveals each invocation's args + detail in a sub-list. Single-call rows keep the prior layout; merged rows aggregate status (any pending → pending, any fail → fail, else ok).
 - **Tool group horizontal wrap**: `.agent-tool-group` switched from vertical stack to `flex-direction: row` with `flex-wrap: wrap`, so consecutive tool-call chips sit side-by-side and only wrap when the chat column runs out of width.
+- **Per-turn usage stats footer**: new `AgentEvent::TurnUsage { input_tokens, output_tokens, ttft_ms, elapsed_ms }` emitted at the end of each turn from both the OpenAI-compatible (`stream_options.include_usage`) and Anthropic (`message_start.usage` + `message_delta.usage`) paths. TTFT is measured from request send to first streamed content/reasoning delta. The frontend accumulates per-workspace totals in a new `ChatUsageStats` field on `WorkspaceEntry` (serde-default so old snapshots load) and renders a compact mono footer under the chat log: `N turns · in {tokens} · out {tokens} · {tok/s} · ttft {ms|s}`. Footer is hidden until the first turn produces data; resets on Reset Conversation.
+- **Copy + Redo buttons on assistant answers**: each assistant chat bubble grew an action row with a Copy button (writes the markdown to the system clipboard via `navigator.clipboard`, switches to a check icon for 1.4 s) and a Redo button (re-submits the previous user-turn prompt). `DisplayTimelineItem::Assistant` carries the preceding user text so Redo knows what to replay; the Redo button is hidden for the welcome bubble. Actions fade up from `opacity: 0.55` to full on hover for visual restraint.
+- **Subagent prompt hardening**: subagent system prompt restructured into `# Tools` / `# Required execution flow` / `# Forbidden behaviors` sections with a mandatory first `list_workspace_files {"path":"."}` call when `workspace_read` is provisioned. Explicit ban on `status:"blocked"` without a prior workspace probe and on paraphrasing tool errors as "tools unavailable".
+- **Subagent server-side blocked-without-trying guard**: new `validate_submit` rejects a `submit_result` with `status:"blocked"` when the role had `workspace_read` but the agent never called `list_workspace_files`, `read_workspace_file`, or `workspace_search`. The rejection is fed back into the conversation as a tool response so the loop continues, forcing the model to actually probe access before re-submitting. `handle_tool_call` now returns a `ToolCallOutcome` enum (`SubmitAccepted` / `SubmitRejected(msg)` / `NotSubmit`) wired into both the OpenAI and Anthropic subagent loops. 4 unit tests pin the contract.
+- **`allowedToolGroups` schema constrained**: `subagents.run` JSON schema now enums `allowedToolGroups.items` to the 9 valid group strings (`environment_read`, `workspace_read`, `diff_read`, `git_read`, `memory_read`, `plans_read`, `tasks_read`, `rules_skills_read`, `web_read`). Previously the array was `{type: string}` with no constraint, so the coordinator could invent names like `"file_access"` / `"files"` and silently end up with an empty subagent toolset.
+- **Strict toolgroup parser + role-defaults fallback**: new `parse_allowed_groups_strict(names) → (valid, unknown)` separates parseable groups from typos. `subagents::run` surfaces the unknowns via a `SubagentStep` with `status:"warning"` listing the bad names and the valid alternatives, and falls back to the role's defaults instead of spawning a subagent with only `submit_result`. 2 new unit tests cover the path.
+- **Subagent tool-roster diagnostic step**: every subagent emits a `SubagentStep` immediately after `SubagentStarted` listing the actual provisioned tools (`Provisioned N tool(s): list_workspace_files, read_workspace_file, …`). When a model claims "no tools" the operator can compare against this list in one glance and tell hallucination from real misprovisioning.
+- **Subagent tools list `×N` compaction**: consecutive same-named tool calls inside a subagent card collapse into one row with a `×N` mint-green badge — same merge logic the main timeline uses. `Search workspace ×5` instead of five identical rows.
 
 ### Changed
 
 - **Docs**: README, developer setup, build guide, and `.env.release.example` now document the setup and cross-platform release automation paths.
 - **Dependencies**: upgraded `leptos` 0.7 → 0.8, `leptos_icons` 0.5 → 0.7, `icondata` 0.5 → 0.7. Leptos 0.8 is backward-compatible for the signal / effect / callback / event-listener APIs in use; only Lucide icon renames required code changes (`LuFileEdit → LuFilePenLine`, `LuPlusCircle → LuCirclePlus`, `LuSendHorizonal → LuSendHorizontal`, `LuAlertTriangle → LuTriangleAlert`, `LuTerminalSquare → LuSquareTerminal`, `LuPlayCircle / LuAlertCircle / LuCheckCircle / LuMinusCircle → LuCircle*` variants).
 - **Command palette shortcut**: tmux-style chord moved from `Ctrl+B :` to `Ctrl+B p`. To free `p`, `ToggleRightPanel` (formerly `Ctrl+B p`) was reassigned to `Ctrl+B r`. Classic-mode shortcuts (`Ctrl+Shift+P` palette, `Ctrl+P` side panel) unchanged. Hint strings in `en_us.rs` / `de_de.rs` updated.
 - **Subagent card polish**: dedicated CSS for the subagent timeline group — name and status now separated by a baseline-aligned `gap` (no more `scanblocked` run-together), font sizes shrunk (`0.7rem` name / `0.62rem` status / `0.68rem` summary / `0.64rem` tools), default `<details>` marker hidden in favour of the existing chevron pattern.
+- **Tool-loop round budgets raised**: `MAX_ROUNDS` for both the OpenAI-compatible and Anthropic coordinator loops bumped from `12 → 36`; `MAX_SUBAGENT_ROUNDS` from `8 → 24`. The previous limits aborted long multi-step turns mid-investigation, especially in subagents that need several file-read rounds before they can synthesize findings.
+- **Subagent skill doc — `allowedToolGroups` documented**: `harness_skills/subagents.md` now lists every valid `allowedToolGroups` string with its tool-coverage, recommends omitting the field entirely (defaults are sensible), and explicitly warns against invented names like `"file_access"` / `"files"` / `"shell_exec"`.
 
 ### Fixed
 

src/workbench/agent_panel/mod.rs

@@ -405,11 +405,18 @@ pub fn AgentPanelDock() -> impl IntoView {
                 >
                     <ol class="agent-chat-list" aria-label=move || i18n.tr(I18nKey::AgTimelineAria)()>
                         {move || {
+                            let on_redo = Callback::new(move |text: String| {
+                                draft.set(text);
+                                submit_turn(
+                                    wb, i18n, draft, busy, status_line,
+                                    timeline, task_snapshot, thinking_open, voice_handle,
+                                );
+                            });
                             compact_timeline(timeline.get())
                                 .into_iter()
                                 .enumerate()
                                 .map(|(idx, entry)| {
-                                    view! { <TimelineRow idx=idx entry=entry i18n=i18n thinking_open=thinking_open voice_handle=voice_handle /> }
+                                    view! { <TimelineRow idx=idx entry=entry i18n=i18n thinking_open=thinking_open voice_handle=voice_handle on_redo=on_redo /> }
                                 })
                                 .collect_view()
                         }}

src/workbench/agent_panel/timeline.rs

@@ -19,7 +19,13 @@ use std::collections::HashMap;
 #[derive(Clone, Debug, PartialEq)]
 pub enum DisplayTimelineItem {
     User { text: String },
-    Assistant { text: String },
+    Assistant {
+        text: String,
+        /// Latest user-message text preceding this assistant block — used as
+        /// the "Redo" button's payload. `None` for the welcome/system bubble
+        /// and for any assistant block that has no preceding user turn.
+        prev_user: Option<String>,
+    },
     ToolGroup(Vec<ToolActivity>),
     SubagentGroup(SubagentGroup),
     Thinking { text: String, done: bool },
@@ -422,6 +428,7 @@ fn synthesize_completion_message(rows: &[TimelineItem]) -> Option<String> {
 pub fn compact_timeline(items: Vec<TimelineItem>) -> Vec<DisplayTimelineItem> {
     let mut out = Vec::new();
     let mut pending_tools = Vec::new();
+    let mut last_user_text: Option<String> = None;
 
     let flush_tools = |out: &mut Vec<DisplayTimelineItem>,
                        pending_tools: &mut Vec<ToolActivity>| {
@@ -436,11 +443,15 @@ pub fn compact_timeline(items: Vec<TimelineItem>) -> Vec<DisplayTimelineItem> {
         match item {
             TimelineItem::User { text } => {
                 flush_tools(&mut out, &mut pending_tools);
+                last_user_text = Some(text.clone());
                 out.push(DisplayTimelineItem::User { text });
             }
             TimelineItem::Assistant { text } => {
                 flush_tools(&mut out, &mut pending_tools);
-                out.push(DisplayTimelineItem::Assistant { text });
+                out.push(DisplayTimelineItem::Assistant {
+                    text,
+                    prev_user: last_user_text.clone(),
+                });
             }
             TimelineItem::Tool(tool) => pending_tools.push(tool),
             TimelineItem::Thinking { text, done } => {
@@ -563,6 +574,7 @@ pub fn TimelineRow(
     i18n: I18nService,
     thinking_open: RwSignal<HashMap<usize, bool>>,
     voice_handle: VoiceOrbHandle,
+    on_redo: Callback<String>,
 ) -> impl IntoView {
     let line_no = format!("{:02}", idx + 1);
     match entry {
@@ -576,14 +588,65 @@ pub fn TimelineRow(
             </li>
         }
         .into_any(),
-        DisplayTimelineItem::Assistant { text } => {
+        DisplayTimelineItem::Assistant { text, prev_user } => {
             let tts_text = text.clone();
+            let copy_text = text.clone();
+            let redo_text = prev_user.clone();
+            let copied = RwSignal::new(false);
             view! {
             <li class="agent-chat-line agent-chat-line--agent">
                 <ChatLineIndexColumn line_no=line_no.clone() tts_text=Some(tts_text) voice_handle=voice_handle />
                 <div class="agent-chat-body">
                     <strong>{move || i18n.tr(I18nKey::AgAssistant)()}</strong>
                     <div class="workbench-agent-markdown" inner_html=render_markdown_to_html(&text)></div>
+                    <div class="agent-chat-actions">
+                        <button
+                            type="button"
+                            class="agent-chat-action"
+                            title="Copy answer to clipboard"
+                            aria-label="Copy answer"
+                            on:click=move |_| {
+                                let text = copy_text.clone();
+                                copied.set(true);
+                                leptos::task::spawn_local(async move {
+                                    if let Some(win) = web_sys::window() {
+                                        let clipboard = win.navigator().clipboard();
+                                        let promise = clipboard.write_text(&text);
+                                        let _ = wasm_bindgen_futures::JsFuture::from(promise).await;
+                                    }
+                                    gloo_timers::future::TimeoutFuture::new(1400).await;
+                                    copied.set(false);
+                                });
+                            }
+                        >
+                            {move || if copied.get() {
+                                view! { <LxIcon icon=icondata::LuCheck width="0.78rem" height="0.78rem" /> }
+                            } else {
+                                view! { <LxIcon icon=icondata::LuCopy width="0.78rem" height="0.78rem" /> }
+                            }}
+                        </button>
+                        <Show when={
+                            let r = redo_text.clone();
+                            move || r.as_ref().is_some_and(|s| !s.trim().is_empty())
+                        }>
+                            <button
+                                type="button"
+                                class="agent-chat-action"
+                                title="Redo this turn (resubmit the same prompt)"
+                                aria-label="Redo"
+                                on:click={
+                                    let r = redo_text.clone();
+                                    move |_| {
+                                        if let Some(text) = r.clone() {
+                                            on_redo.run(text);
+                                        }
+                                    }
+                                }
+                            >
+                                <LxIcon icon=icondata::LuRefreshCw width="0.78rem" height="0.78rem" />
+                            </button>
+                        </Show>
+                    </div>
                 </div>
             </li>
         }

styles.css

@@ -2741,6 +2741,45 @@ button.workbench-shortcut-row--action:focus-visible {
   border-color: rgba(255, 120, 120, 0.4);
 }
 
+.agent-chat-actions {
+  display: flex;
+  align-items: center;
+  gap: 0.32rem;
+  margin-top: 0.36rem;
+  opacity: 0.55;
+  transition: opacity 140ms ease;
+}
+
+.agent-chat-line--agent:hover .agent-chat-actions {
+  opacity: 1;
+}
+
+.agent-chat-action {
+  display: inline-flex;
+  align-items: center;
+  justify-content: center;
+  width: 1.5rem;
+  height: 1.5rem;
+  padding: 0;
+  border: 1px solid rgba(255, 255, 255, 0.08);
+  border-radius: 0.4rem;
+  background: rgba(255, 255, 255, 0.025);
+  color: rgba(241, 242, 245, 0.72);
+  cursor: pointer;
+  transition: background 120ms ease, border-color 120ms ease, color 120ms ease;
+}
+
+.agent-chat-action:hover {
+  background: rgba(255, 255, 255, 0.06);
+  border-color: rgba(255, 255, 255, 0.16);
+  color: rgba(241, 242, 245, 0.95);
+}
+
+.agent-chat-action:focus-visible {
+  outline: 2px solid rgba(143, 217, 196, 0.6);
+  outline-offset: 1px;
+}
+
 .agent-chat-usage {
   display: flex;
   flex-wrap: wrap;