Skip to content

Skip Safe Balances for non-safes #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025
Merged

Skip Safe Balances for non-safes #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9734c5e
Skip Safe Balances for non-safes
bh2smith Jun 20, 2025
85dd1f8
Format code
bh2smith Jun 20, 2025
ed611f4
Remove no longer necessary test
bh2smith Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/agent-sdk/src/evm/safe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { type Address, checksumAddress, parseUnits } from "viem";
import { type UserToken, ZerionAPI } from "zerion-sdk";
import { scientificToDecimal } from "../misc";
import { getClient } from "near-safe";

export interface TokenBalance {
tokenAddress: string | null; // null for native token
Expand Down Expand Up @@ -53,6 +54,12 @@ export async function getSafeBalances(
address: Address,
zerionKey?: string,
): Promise<TokenBalance[]> {
const client = await getClient(chainId);
const codeAt = await client.getCode({ address });
if (!codeAt) {
// Not a Safe - Get balances from Zerion.
return getZerionBalances(chainId, address, zerionKey);
}
const baseUrl = safeTxServiceUrlFor(chainId);
if (!baseUrl) {
console.warn(
Expand Down
5 changes: 0 additions & 5 deletions packages/agent-sdk/tests/evm/safe.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { zeroAddress } from "viem";
import {
getSafeBalances,
flatSafeBalances,
Expand All @@ -17,10 +16,6 @@ describe("getSafeBalances", () => {
console.warn = originalWarn;
});

it("should throw error for unsupported chain ID", async () => {
await expect(getSafeBalances(999, zeroAddress)).resolves.toEqual([]);
});

it("zerionToTokenBalance should transform scientific notation balance", () => {
expect(
zerionToTokenBalance({
Expand Down