branch releases fix #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
requested changes
Feb 5, 2025
Member
bh2smith
left a comment
bh2smith
left a comment
There was a problem hiding this comment.
Way too many irrelevant changes. Looks a lot like the entire file was replaced with some AI proposed outdated new file.
sainthiago
approved these changes
Feb 5, 2025
bh2smith
reviewed
Feb 5, 2025
| SHORT_SHA=$(git rev-parse --short HEAD) | ||
| # TODO: make this dynamic https://github.com/BitteProtocol/make-agent/issues/56 | ||
| BASE_VERSION="0.2.1" # Define a base version | ||
| BASE_VERSION=$(node -p "require('./package.json').version") |
Member
There was a problem hiding this comment.
This is no good.
Please consider following the linked issue: #56
Also save this for another PR - it is an unrelated change.
bh2smith
reviewed
Feb 5, 2025
package.json
Outdated
| "name": "make-agent", | ||
| "type": "module", | ||
| "version": "0.0.22-7", | ||
| "version": "0.2.3", |
Member
There was a problem hiding this comment.
We will not be keeping this updated. We should not rely on it.
bh2smith
reviewed
Feb 5, 2025
bh2smith
reviewed
Feb 5, 2025
bh2smith
reviewed
Feb 5, 2025
| run: npm publish --access public --tag beta | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}} | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
Member
There was a problem hiding this comment.
New line at EOF!
Suggested change
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | |
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | |
bh2smith
reviewed
Feb 5, 2025
|
|
||
| jobs: | ||
| branch-release: | ||
| branch_release: |
Member
There was a problem hiding this comment.
Suggested change
| branch_release: | |
| branch-release: |
This was referenced Feb 6, 2025
Closed
Merged
bh2smith
added a commit
that referenced
this pull request
Feb 6, 2025
Closes #72 and closes #60 The problem before was that we didn't fetch the history (i.e. fetch depth 0) See here that the correct version tag was detected: https://github.com/BitteProtocol/make-agent/actions/runs/13176723432/job/36777678912?pr=73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56