Skip to content

fix(prerenderer): HEAD requests cause double requests #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

fix(prerenderer): HEAD requests cause double requests #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/src/run-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default function render(pathname, args='', body, locals={}, cb) {
dispose()

cb(null, data || {
html: lastHtml
html: locals.isHead ? '' : lastHtml
, title: lastState.title
, status: lastState.view == 'notFound' ? 404
: lastState.view == 'error' ? lastState.error.status || 400
Expand All @@ -38,7 +38,7 @@ export default function render(pathname, args='', body, locals={}, cb) {
}

function htmlUpdate(html) {
lastHtml = html
if (!locals.isHead) lastHtml = html
}
function stateUpdate(S) {
if (!lastState) { // the first state
Expand Down
2 changes: 1 addition & 1 deletion prerender-server/client
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
../client/src
../client/dist
26 changes: 13 additions & 13 deletions prerender-server/src/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ import request from 'superagent'
import l10n from '../client/l10n'
import render from '../client/run-server'

const themes = [ 'light', 'dark' ]
, langs = Object.keys(l10n)
, baseHref = process.env.BASE_HREF || '/'
, canonBase = process.env.CANONICAL_URL ? process.env.CANONICAL_URL.replace(/\/$/, '') : null
, apiUrl = process.env.API_URL.replace(/\/$/, '')
const themes = ['light', 'dark']
, langs = Object.keys(l10n)
, baseHref = process.env.BASE_HREF || '/'
, canonBase = process.env.CANONICAL_URL ? process.env.CANONICAL_URL.replace(/\/$/, '') : null
, apiUrl = process.env.API_URL.replace(/\/$/, '')

const rpath = p => path.join(__dirname, p)

Expand All @@ -37,7 +37,7 @@ app.use((req, res, next) => {
if (!langs.includes(lang)) lang = 'en'
if (req.query.lang && req.cookies.lang !== lang) res.cookie('lang', lang)

render(req._parsedUrl.pathname, req._parsedUrl.query || '', req.body, { theme, lang }, (err, resp) => {
render(req._parsedUrl.pathname, req._parsedUrl.query || '', req.body, { theme, lang, isHead: req.method === 'HEAD' }, (err, resp) => {
if (err) return next(err)
if (resp.redirect) return res.redirect(301, baseHref + resp.redirect.substr(1))
if (resp.errorCode) {
Expand All @@ -48,11 +48,11 @@ app.use((req, res, next) => {
res.status(resp.status || 200)
res.render(indexView, {
prerender_title: resp.title
, prerender_html: resp.html
, canon_url: canonBase ? canonBase + req.url : null
, noscript: true
, theme
, t: l10n[lang]
, prerender_html: resp.html
, canon_url: canonBase ? canonBase + req.url : null
, noscript: true
, theme
, t: l10n[lang]
})
})

Expand All @@ -64,10 +64,10 @@ if (process.env.SOCKET_PATH) {
if (fs.statSync(process.env.SOCKET_PATH).isSocket()) {
fs.unlinkSync(process.env.SOCKET_PATH)
}
} catch (_) {}
} catch (_) { }
}

app.listen(process.env.SOCKET_PATH || process.env.PORT || 5001, function(){
app.listen(process.env.SOCKET_PATH || process.env.PORT || 5001, function () {
let addr = this.address()
if (addr.address) addr = `${addr.address}:${addr.port}`
console.log(`HTTP server running on ${addr}`)
Expand Down