Skip to content

Fixed security issues #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Fixed security issues #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61daddf
fix CVE-2022-41418
tree-chtsec Oct 24, 2022
9a8a7e3
fix CVE-2022-41417.
tree-chtsec Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions BlogEngine/BlogEngine.Core/Data/UsersRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ public BlogUser Add(BlogUser user)
if (!Security.IsAuthorizedTo(Rights.CreateNewUsers))
throw new UnauthorizedAccessException();

if (user.UserName.Contains("/") || user.UserName.Contains(@"\"))
throw new ApplicationException("Error adding new user; Invalid character detected in UserName");

// create user
var usr = Membership.CreateUser(user.UserName, user.Password, user.Email);
if (usr == null)
Expand Down
2 changes: 1 addition & 1 deletion BlogEngine/BlogEngine.Core/Providers/FileSystemProviders/XmlFileSystemProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ private static string BlogAbsolutePath(string VirtualPath)
private static string RelativeFilePath(string VirtualPath)
{
VirtualPath = VirtualPath.Replace("//","/").Trim();
if (VirtualPath.ToLower().Contains(FileContainerRoot.ToLower()))
if (VirtualPath.ToLower().Contains(FileContainerRoot.ToLower()+"/") || VirtualPath.ToLower() == FileContainerRoot.ToLower())
return VirtualPath;

// ex: Oct 18 2012, added this to handle the case on the File Manager where if
Expand Down
4 changes: 3 additions & 1 deletion BlogEngine/BlogEngine.NET/AppCode/Api/UploadController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ public HttpResponseMessage Post(string action, string dirPath = "")
dir = BlogService.GetDirectory("/avatars");
var dot = fileName.LastIndexOf(".");
var ext = dot > 0 ? fileName.Substring(dot) : "";
if (User.Identity.Name.Contains("/") || User.Identity.Name.Contains(@"\"))
throw new ApplicationException("Invalid character detected in UserName");
var profileFileName = User.Identity.Name + ext;

var imgPath = HttpContext.Current.Server.MapPath(dir.FullPath + "/" + profileFileName);
Expand Down Expand Up @@ -157,4 +159,4 @@ private void UploadVideo(string virtualFolder, HttpPostedFile file, string fileN
}

#endregion
}
}