Sync fork #1
Merged
Sync fork #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add ignoreCommentContent options in indent * add tests * add options doc * Update indent.js * update * Update indent.md
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to version 0.48.0 and introduces a new ignoreComment option for the indent rule that allows HTML comment indentation to be skipped during linting.
Key changes:
- Version bumped from 0.47.x to 0.48.0 across all packages
- Added
ignoreCommentoption to the indent rule configuration - Refactored comment indentation logic into a separate visitor that can be conditionally applied
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lerna.json | Updated root version to 0.48.0 |
| packages/website/package.json | Bumped version and updated dependency references to 0.48.0 |
| packages/web-linter/package.json | Bumped version to 0.48.0 |
| packages/types/package.json | Bumped version to 0.48.0 |
| packages/template-syntax-parser/package.json | Bumped version and updated dependency reference to 0.48.0 |
| packages/template-parser/package.json | Bumped version and updated dependency reference to 0.48.0 |
| packages/parser/package.json | Bumped version and updated dependency references to 0.48.0 |
| packages/integration-test/package.json | Bumped version to 0.48.0 |
| packages/eslint-plugin/package.json | Bumped version and updated dependency references to 0.48.0 |
| packages/cli/package.json | Bumped version and updated dependency references to 0.48.0 |
| packages/eslint-plugin/lib/rules/indent/indent.js | Added ignoreComment option and refactored comment visitor to be conditionally applied |
| packages/eslint-plugin/tests/rules/indent.test.js | Added test cases for the new ignoreComment option |
| docs/rules/indent.md | Documented the new ignoreComment option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add ignoreCommentContent options in indent
add tests
add options doc
Update indent.js
update
Update indent.md