Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

@olupton
Copy link
Contributor

@olupton olupton commented Dec 17, 2021

Description
Adds a reset() method to the corenrn_parameters struct, which resets members to their default values.
This should help with https://github.com/BlueBrain/CoreNeuron/pull/701/files#r758813278.
It is challenging to support corenrn_param = corenrn_parameters{} as a way of doing the same thing because of the CLI11 struct embedded inside.

Use certain branches for the SimulationStack CI
CI_BRANCHES:NEURON_BRANCH=master,

@olupton olupton mentioned this pull request Dec 17, 2021
2 tasks
@olupton olupton requested a review from alkino December 17, 2021 09:25
Copy link
Contributor

@alexsavulescu alexsavulescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@olupton
Copy link
Contributor Author

olupton commented Dec 17, 2021

retest this please Jenkins

2 similar comments
@olupton
Copy link
Contributor Author

olupton commented Dec 17, 2021

retest this please Jenkins

@olupton
Copy link
Contributor Author

olupton commented Dec 17, 2021

retest this please Jenkins

@olupton olupton merged commit 2ffa262 into master Dec 17, 2021
@olupton olupton deleted the olupton/corenrn-parameters-reset branch December 17, 2021 13:48
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants