Skip to content

Improve 'LanguageTest::test_locales_config_key_set_properly' #3490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrii-bodnar wants to merge 2 commits into from
Closed

Improve 'LanguageTest::test_locales_config_key_set_properly' #3490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e6d75f
Improve 'LanguageTest::test_locales_config_key_set_properly'
andrii-bodnar Jun 9, 2022
a74211b
Fix Crowdin name
andrii-bodnar Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/language_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Language Request
description: Request a new language to be added to CrowdIn for you to translate
description: Request a new language to be added to Crowdin for you to translate
labels: [":earth_africa: Translations"]
assignees:
- ssddanbrown
Expand All @@ -23,7 +23,7 @@ body:
This issue template is to request a new language be added to our [Crowdin translation management project](https://crowdin.com/project/bookstack).
Please don't use this template to request a new language that you are not prepared to provide translations for.
options:
- label: I confirm I'm offering to help translate for this new language via CrowdIn.
- label: I confirm I'm offering to help translate for this new language via Crowdin.
required: true
- type: markdown
attributes:
Expand Down
8 changes: 5 additions & 3 deletions tests/LanguageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@ protected function setUp(): void
public function test_locales_config_key_set_properly()
{
$configLocales = config('app.locales');
sort($configLocales);
sort($this->langs);
$this->assertEquals(implode(':', $configLocales), implode(':', $this->langs), 'app.locales configuration variable does not match those found in lang files');

$this->assertEmpty(
array_diff($configLocales, $this->langs),
'app.locales configuration variable does not match those found in lang files'
);
}

// Not part of standard phpunit test runs since we sometimes expect non-added langs.
Expand Down