Remove unnecessary code + Fix config_manager.h#155
Merged
hyv1001 merged 2 commits intoBoomingTech:mainfrom Apr 28, 2022
ShenMian:patch-0
Merged
Remove unnecessary code + Fix config_manager.h#155hyv1001 merged 2 commits intoBoomingTech:mainfrom ShenMian:patch-0
hyv1001 merged 2 commits intoBoomingTech:mainfrom
ShenMian:patch-0
Conversation
Contributor
ShenMian
commented
Apr 27, 2022
ShenMian
commented
- 因为 PublicSingleton 是一个不可拷贝的类, 因此其子类不需要再显示声明拷贝构造函数和赋值构造函数删除.
- SceneObject 中的部分函数实现和默认的行为无异, 因此删去.
- 防止单例类 ConfigManager 创建多个实例.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.