Skip to content

Several minor fixes#44

Merged
hyv1001 merged 3 commits intoBoomingTech:mainfrom
Altair-Alpha:main
Apr 6, 2022
Merged

Several minor fixes#44
hyv1001 merged 3 commits intoBoomingTech:mainfrom
Altair-Alpha:main

Conversation

@Altair-Alpha
Copy link
Copy Markdown
Contributor

@Altair-Alpha Altair-Alpha commented Apr 6, 2022

Just some little fixes here:

  1. return value shouldn't be moved as it may inhibit RVO. Ref: stackoverflow
  2. primitive types parameters such as float doesn't need to be passed by reference.
  3. probably typos? (well, the code seems not being used anyway)

Still reading the full source code:)

@Altair-Alpha Altair-Alpha changed the title Eliminate move on return value Several minor fixes Apr 6, 2022
@hyv1001 hyv1001 merged commit 529a140 into BoomingTech:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants