Skip to content

Refactor: Use STL#73

Merged
hyv1001 merged 2 commits intoBoomingTech:mainfrom
wlbksy:stl
Apr 7, 2022
Merged

Refactor: Use STL#73
hyv1001 merged 2 commits intoBoomingTech:mainfrom
wlbksy:stl

Conversation

@wlbksy
Copy link
Copy Markdown
Contributor

@wlbksy wlbksy commented Apr 7, 2022

  1. std::max std::min std::clamp is generic
  2. std::hypot is better than sqrt(sqr())

ShenMian
ShenMian reviewed Apr 7, 2022
View reviewed changes
Comment thread engine/source/runtime/core/math/quaternion.cpp Outdated
@hyv1001 hyv1001 merged commit 3776f18 into BoomingTech:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ShenMian ShenMian ShenMian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wlbksy @ShenMian @hyv1001