Skip to content

local dev toolchain broken #679

@100ideas

Description

@100ideas

Current behavior

package.json scripts for starting development build in browser lead to exception that crashes app.

App.tsx#L140 in current master (374afb3) is part of the problem - the code tries to initializate an IPC channel using a nonexistant function that would otherwise have been passed in from the electron environment in window.__ELECTRON_ONLY in src/lib/electronOnly.ts; instead the latter code provides an empty object, which the code in App.tsx chokes on.

rolling back to commit 691a7bf fixes this problem. This was the earliest commit I saw before the failing code block was added to App.tsx: https://github.com/BoostIO/BoostNote.next/compare/691a7bf..374afb3c#diff-86963609bec6fda3d34233676d5ae33f6aa4b9bbe2758a10cd4863b704b37093

Please include some screenshots with the developer tools open (console tab) when you report a bug.

current master (at 374afb3):
boostnote next at master commit 374afb3

last working commit (at 691a7bf):
boostnote next at master commit 691a7bf - works

Expected behavior

boostnote.next w/ live-reload loads in browser at localhost:3000 after following contribution instructions and running npm dev script to boot local server. related to #400, #397.

Steps to reproduce

  1. in vanilla environment, follow the current readme.md instructions and try to start local development server
  2. fail
  3. $ git checkout 691a7bf
  4. unfail

Environment

Desktop/Web

  • Boost Note.next version: failing: 0.10.2; working: 0.9.1
  • OS version and name: MacOS 10.15.7 node 14 chrome 86

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions