Updated remove storage strings #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marilari88
reviewed
Apr 28, 2020
Contributor
marilari88
left a comment
marilari88
left a comment
There was a problem hiding this comment.
There are still many labels and description hardcoded. As said in #433 we've is a partally traslated application. I think we should start listing all the missing traslations and then work to introduce them in the code.
ZeroX-DG
requested changes
Apr 29, 2020
ZeroX-DG
added
the
awaiting changes 🖊️
Contributor
Author
|
The |
ZeroX-DG
approved these changes
Apr 30, 2020
Member
ZeroX-DG
left a comment
ZeroX-DG
left a comment
There was a problem hiding this comment.
That's cool, I'll open an issue for everyone to fix their language later 👍
ZeroX-DG
added
approved 👍
Rokt33r
pushed a commit
that referenced
this pull request
May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
RemovetoDeleteStorage.Other localization languages needs update due to this change.