fix(markdown-code-block-lang-mode): Fix accessing element of mimes and ext when they are undefined. #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…d ext when they are undefined
theKastle
force-pushed
the
fix-undefined-code-mirror-language-mimes-ext
branch
from
916ee1e to
52139af
Compare
theKastle
changed the title
Member
|
@theKastle Thanks for submitting this pr. I didn't expect that none of them are available. I'll test a bit more and try to make it a bit better. |
Member
|
LGTM! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d ext when they are undefined.
When code block is set in
dockerfilelanguage mode, propertiesmimesandextare undefined so I add optional chaining when accessing their element.