Skip to content

apply theme color to slider in MarkdownSplitEditor #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rokt33r merged 1 commit into from
Jul 8, 2019
Merged

apply theme color to slider in MarkdownSplitEditor #3055

Rokt33r merged 1 commit into from
Jul 8, 2019

Conversation

@amedora
Copy link
Contributor

@amedora amedora commented Jun 4, 2019

Description

Define "border-left" and apply theme color to slider in MarkdownSplitEditor.
Once #3048 has merged, this PR will be merged.

slider-border-color

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the approved 👍 Pull request has been approved by sufficient reviewers. label Jun 4, 2019
ZeroX-DG
ZeroX-DG approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG changed the title [WIP] apply theme color to slider in MarkdownSplitEditor apply theme color to slider in MarkdownSplitEditor Jun 10, 2019
@Rokt33r Rokt33r merged commit 0c7a1e8 into BoostIO:master Jul 8, 2019
@Rokt33r Rokt33r added this to the v0.12.0 milestone Jul 8, 2019
@amedora amedora deleted the fix-3005 branch July 28, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees

No one assigned

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Milestone

v0.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@amedora @ZeroX-DG @Rokt33r