changes folder for a note from the note's breadcrumbs#348
changes folder for a note from the note's breadcrumbs#348pfftdammitchris wants to merge 2 commits intoBoostIO:masterfrom
Conversation
…licking on the storage - Replaced the render block with the ts-ignore with a more type safety implementation - Fixed dropdown menu not closing when clicking on the name of the storage again
|
also, some of the smaller components throughout these molecules should be abstracted out into separate components and/or memoized because they're being re-rendered look at the image below where i click on certain components. the whole app repaints itself everytime. its causing spikes
should i optimize them and make pull requests? edit: also if we abstract some of these components out i can make the dropdown more robust but i didn't want to go too far ahead without mentioning this first |
|
no, not in here. It should be presented as a separated pr! I'm going to deal with the problem but I still didn't start it yet. If you want to fix it, you can just go ahead now. |
|
The code looks good to me but I'm a bit skeptical to accept this suggestion. I think we should discuss about this more in the original issue. |
|
I'll close this for now. Let's reopen it after we find we want this again. |
2 participants
fixes #347
before this pull request when we click on the storage name, it changes the mode to "All Notes" but they can already do that themselves by clicking that on the left side. so this pull request proposes a useful alternative to replace the note's storage from a dropdown menu instead