Add support for images copied from clipboard#486
Closed
lahgolz wants to merge 2 commits intoBoostIO:masterfrom
lahgolz:paste-screenshot
Closed
Add support for images copied from clipboard#486lahgolz wants to merge 2 commits intoBoostIO:masterfrom lahgolz:paste-screenshot
lahgolz wants to merge 2 commits intoBoostIO:masterfrom
lahgolz:paste-screenshot
Conversation
ZeroX-DG
requested changes
May 26, 2020
Member
ZeroX-DG
left a comment
ZeroX-DG
left a comment
There was a problem hiding this comment.
Can you change your code please?
| for (let i = 0; i < files.length; i++) { | ||
| const file = files[i] | ||
| const newName = String(file.lastModified) | ||
| const newFile = renameFile(file, newName) |
Member
There was a problem hiding this comment.
We might need to discuss more about file naming here? How should we generate a name for the attachment? @Rokt33r
Contributor
Author
There was a problem hiding this comment.
Since all the screenshots, at least in Linux, have the same name (image.png in my case), I thought that using the timestamp for the name was a good idea, but yes, it can be rethought.
Contributor
Author
|
Since it was added in #583, I close this one. |
Member
|
@EnderDragonneau I'm sorry that I totally forgot about this PR. Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #468
Added support for images copied from clipboard (and a system to rename them since all the screenshots have the same name, it can be used later on to rename attachments)