Fix storage edit page not scrolling because of height not set on cont…#524
Merged
Rokt33r merged 1 commit intoBoostIO:masterfrom Jul 26, 2020
Merged
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix storage edit page not scrolling because of height not set on container.
I tried managing it multiple ways, one being adding container above "ScrollableComponent" but this either don't work or requires a lot of css to deal with it (for example similar to TabComponent, Container, but with some top offset so it skips movable header)
Maybe this could also be fixed by having general 100% height on some root container, instead of page container.
Should I run some tests, it's a small change, but maybe this will break some other components using the PageContainer style?