fixed disappearing scroll bar #2033
Conversation
|
@ZeroX-DG Could you attach a screenshot after the fix? |
|
No problem. BEFORE:
AFTER:
|
|
I think that it is not bad at present.. |
|
@sosukesuzuki As you can see the current scroll bar will disappear after a short period of time and only reappear if you resize the app or focus on a text box and hit the page up or page down key. The new one make sure that the scroll bar will never disappear. |
|
@ZeroX-DG I know. However, I think that we are not in trouble. Why are you troubled? |
sosukesuzuki
added
awaiting changes 🖊️
|
I started to think this is not related to codemirror but instead electron? I've removed codemirror scroll addon and the problem is still persist and also I've found the same issue on Atom github page: atom/atom#15107 , but it seem that their solution is just like me. But how can you guys don't experience this issue? I experienced this issue on both Boostnote and my side project which is fixed by using the traditional way to create scroll bar. |
|
Hmm @sosukesuzuki For me, it looks a problem to be fixed. I'll review this. |
Rokt33r
added
awaiting review ❇️
|
@ZeroX-DG How can I reproduce this problem? It works fine for me. |
|
Hey @Rokt33r , why your scroll bar is the default scroll bar of chrome? Mine is not!
|
|
I'll try again. |
|
Hmm.. mine never disappear... Do you have any clue why it doesn't happen to me? Btw, I didn't configure my scroll. I assume the reason might be that I'm running windows via Parallels. |
|
I have no idea what's happening but I think if your scroll bar is still the default one then it will not disappear, do you have a linux machine to test it? Maybe it's a linux problem? |
|
@Rokt33r I've just updated to the latest version of Boostnote (0.11.7) and the scroll bars became the default scroll bar of chrome (just like what you have) and it doesn't disappear anymore??? I gonna have to investigate the commit that change the scroll bar, but that's also means the issue is now solved, the scroll bar doesn't disappear anymore, now it just looks ugly and that's a different issue. Should we close this pull request? |
|
Close this issue because the problem is suddenly gone after v0.11.7. |
|
Reopen because it fixes other problem. |
3 participants
The disappearing scroll bar bug is extremely annoying and has been reported here: https://issuehunt.io/repos/53266139/issues/1632
After working on my personal project, I have found a fix for this issue.
This is bug exists due to the style of the scroll bar of codemirror, instead of applying for just codemirror, it applied to the whole window, everything that has its scroll bar unstyled. So the solution is to override that style!