Skip to content

Comments

Localize tooltips for Japanese#2772

Merged
Rokt33r merged 6 commits intoBoostIO:masterfrom
vienai8d:localize_tooltips_ja
Jan 7, 2019
Merged

Localize tooltips for Japanese#2772
Rokt33r merged 6 commits intoBoostIO:masterfrom
vienai8d:localize_tooltips_ja

Conversation

@vienai8d
Copy link
Contributor

@vienai8d vienai8d commented Jan 2, 2019

Description

1. Add translation for Japanese (Documentation change)

0a0c1c4
Translate tooltip texts into Japanese.

2. Localize tooltips for Japanese (Improvement)

Appearance of the tooltips is not good as below.
before

So, I localize the following buttons.

Below is new appearance of the tooltips.
after

3. Fix FullscreenButton (Bug fix)

d0f5ec8

A tooltip text of FullscreenButton is mixed English and Japanese after chaging language from Japanese to English as below.
2019-01-02 13 07 50

This is because hotkey text of the FullscreenButton is decided regardless of current language setting.
To resolve this problem, hotkey is defined in onClick function.

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • 🔘 Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jan 2, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 6, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r January 6, 2019 08:43
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jan 6, 2019

I still need @Rokt33r to review the translation before we can merge this.

@Rokt33r Rokt33r added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Jan 7, 2019
Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rokt33r Rokt33r merged commit d980931 into BoostIO:master Jan 7, 2019
@Rokt33r Rokt33r added next release (v0.11.13) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Jan 7, 2019
@vienai8d vienai8d deleted the localize_tooltips_ja branch January 7, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants