Skip to content

fixes #2931 #3085 #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
juliankoehn wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixes #2931 #3085 #3625

juliankoehn wants to merge 3 commits into from

Conversation

@juliankoehn
Copy link

@juliankoehn juliankoehn commented Aug 19, 2020 •
edited by issuehunt-oss bot
Loading

Description

Fixes issue #2931 and #3085

Old PR 3314 by @uS-aito

fixes bug with html entities, without breaking formatting.

current_state

Screen Shot 2020-08-19 at 10 55 55

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible
  • 🔘 This PR will modify the UI or affects the UX
  • ⚪ This PR will add/update/delete a keybinding
IssueHunt Summary

Referenced issues

This pull request has been submitted to:

@Flexo013 Flexo013 self-assigned this Aug 29, 2020
@Flexo013 Flexo013 added awaiting review ❇️ Pull request is awaiting a review. awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 7, 2020
Flexo013
Flexo013 requested changes Sep 13, 2020
View reviewed changes
@juliankoehn
Update MarkdownPreview.js
6af5751 
Pull BoostIO#3625 CR
@juliankoehn
Update MarkdownPreview.js
f3957a7 
according to CodeReview in PR BoostIO#3625 removed comments
Flexo013
Flexo013 approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@Flexo013 Flexo013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Flexo013 Flexo013 added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flexo013 Flexo013 Flexo013 approved these changes

Assignees

@Flexo013 Flexo013

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juliankoehn @Flexo013