Skip to content

Conversation

@BornToBeRoot
Copy link
Owner

Changes proposed in this pull request

  • Profile file creation flow improved
  • Profile file dialog migrated to a child window

Related issue(s)

  • Fixes #{issue number}

Copilot generated summary

Provide a Copilot generated summary of the changes in this pull request.

Copilot summary

{generated summary}

To-Do

Contributing

By submitting this pull request, I confirm the following:

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors dialog handling for profile files, migrating from CustomDialog to ChildWindow pattern, standardizes event handler naming to use the _OnLoaded suffix, and upgrades the WixToolset SDK to version 6.0.2.

  • Converts async void event handlers to async Task methods with proper command binding
  • Refactors ProfileFileDialog from UserControl to ProfileFileChildWindow (ChildWindow)
  • Adds new encryption prompt when creating profile files

Reviewed Changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
WelcomeChildWindow.xaml.cs/.xaml Renames event handler from ChildWindow_Loaded to ChildWindow_OnLoaded
UpgradeChildWindow.xaml.cs/.xaml Renames event handler from ChildWindow_Loaded to ChildWindow_OnLoaded
ProfileFileDialog.xaml.cs Removes old UserControl-based dialog code
ProfileFileChildWindow.xaml.cs/.xaml Adds new ChildWindow-based dialog implementation with consistent naming
OKMessageChildWindow.xaml.cs/.xaml Renames event handler and removes extra whitespace
OKCancelInfoMessageChildWindow.xaml.cs/.xaml Renames event handler from ChildWindow_Loaded to ChildWindow_OnLoaded
SettingsProfilesViewModel.cs Converts methods from async void to async Task, migrates from CustomDialog to ChildWindow pattern, adds encryption prompt for new profiles
NETworkManager.Setup.wixproj Upgrades WixToolset SDK from 5.0.0 to 6.0.2
Strings.resx/Designer.cs Removes DeleteProfileFileMessage, adds DeleteProfileFileXMessage, EnableEncryptionQuestion, and EnableEncryptionForProfileFileMessage resources
GlobalAssemblyInfo.cs Updates assembly version from 2025.10.18.0 to 2025.11.1.0
Files not reviewed (1)
  • Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mergify mergify bot merged commit 5276e21 into main Nov 8, 2025
4 checks passed
@mergify mergify bot deleted the feature/profile_file_creation branch November 8, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants