Feature: Add Ukrainian (uk-UA)
#3240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BornToBeRoot
added
🎨 design
dependencies
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds Ukrainian (uk-UA) language support to NETworkManager and improves the user interface for the restart-required notification by making it more prominent and informative.
Key changes:
- Added Ukrainian language configuration across localization infrastructure (LocalizationManager, Transifex, flag resources)
- Enhanced the restart-required button with an improved icon (
ProgressCheckinstead ofReloadAlert), visible text label, and a more descriptive tooltip - Broadened
.gitignorepatterns to exclude*.exeand*.dllfiles repository-wide instead of just in the.nugetdirectory
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/transifex.yml |
Added uk_UA to the language mapping for Transifex integration |
.gitignore |
Added repository-wide patterns to ignore *.exe and *.dll files |
.nuget/.gitignore |
Removed the .nuget-specific *.exe pattern (moved to root .gitignore) |
Source/NETworkManager.Localization/LocalizationManager.cs |
Added Ukrainian language entry with display name, native name, flag reference, and culture code |
Source/NETworkManager.Localization/NETworkManager.Localization.csproj |
Included the Ukrainian flag PNG as a resource in the project |
Source/NETworkManager.Localization/Resources/Flags/uk-UA.png |
Added Ukrainian flag image for language selection UI |
Source/NETworkManager.Localization/Resources/Strings.Designer.cs |
Auto-generated code for the new ToolTip_RestartRequired resource string |
Source/NETworkManager.Localization/Resources/Strings.resx |
Added ToolTip_RestartRequired localization string explaining restart requirement |
Source/NETworkManager/MainWindow.xaml |
Updated restart button with new tooltip, improved icon, text label, and removed trailing whitespace |
Scripts/Create-FlagFromSVG.ps1 |
Updated script paths to Ukrainian flag generation (temporary development paths) |
Files not reviewed (1)
- Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+9
to
+10
| $SourcePath = "C:\Temp\ua.svg" | ||
| $DestinationPath = "C:\Temp\uk-UA.png" |
There was a problem hiding this comment.
This script file appears to contain temporary/local paths specific to the development environment. The $SourcePath and $DestinationPath should either be parameterized or reverted to placeholder values (or a previously used language example). Committing developer-specific paths can cause confusion for other contributors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
uk-UA)Related issue(s)
Copilot generated summary
Provide a Copilot generated summary of the changes in this pull request.
Copilot summary
This pull request introduces Ukrainian language support to the application and improves the user interface by clarifying restart requirements when changing settings. The most notable changes are the addition of Ukrainian localization resources and updates to the restart-required tooltip and button visuals.
Localization:
uk-UA) to supported languages in.github/transifex.ymlandLocalizationManager.cs, including display name and flag resources. [1] [2]NETworkManager.Localization.csproj). [1] [2]Create-FlagFromSVG.ps1to generate the Ukrainian flag PNG from SVG.User Interface:
ToolTip_RestartRequiredto both the resource file and designer, and updated the restart button tooltip inMainWindow.xamlto use it. [1] [2] [3]Miscellaneous:
.exepattern from.nuget/.gitignore, which may affect which files are ignored in the NuGet directory.To-Do
Contributing
By submitting this pull request, I confirm the following: