-
Notifications
You must be signed in to change notification settings - Fork 328
[Go] Simple Collector #1976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[Go] Simple Collector #1976
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
64a8d5b
Add a first pass at ClientRegistry
tberman 42db316
Merge branch 'canary' into tberman/go_client_registry
tberman ebfdae2
[Go] Collector
tberman d39dc42
Merge branch 'canary' into tberman/go_collector_simplest_first_version
tberman c031663
Fix the Box issue
tberman b7d3d68
Proper free
tberman 724ff0a
fixing ref-count issues
hellovai d2f905e
removed other method
hellovai 3119e93
Add more collector wrapping
tberman 743af29
Make this a bit easier to read
tberman ca90574
Add LLMCall.selected
tberman ce112ae
Merge branch 'canary' into tberman/go_collector_simplest_first_version
tberman b0a3e20
add more collector interfaces
tberman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| use std::{path::Path, process::Command}; | ||
| use std::path::Path; | ||
|
|
||
| use cbindgen; | ||
| use flatc::flatc; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using
unwrap()on the result ofhttp_body.text(). This FFI boundary should propagate errors instead of panicking on invalid UTF-8 data.