-
Notifications
You must be signed in to change notification settings - Fork 6
Update README with comprehensive AtlasCentricPreprocessor and NativeSpacePreprocessor examples and improved documentation #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…or examples Co-authored-by: neuronflow <7048826+neuronflow@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates README examples to use current preprocessor classes (AtlasCentricPreprocessor and NativeSpacePreprocessor) instead of the deprecated Preprocessor class, providing clear guidance on when to use each workflow.
- Replaced deprecated
PreprocessorwithAtlasCentricPreprocessorin the existing example - Added new complete example for
NativeSpacePreprocessorshowing native space workflow - Updated all file paths to use consistent
Pathobjects and generic placeholders
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
README.md
Outdated
| raw_bet_output_path=output_folder / "raw_bet/t1c_bet_raw.nii.gz", | ||
| raw_skull_output_path=output_folder / "raw_skull/t1c_skull_raw.nii.gz", | ||
| normalized_skull_output_path=output_folder / "normalized_skull/t1c_skull_normalized.nii.gz", |
Copilot
AI
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The order of output paths is inconsistent with the atlas-centric example. In the atlas-centric section (lines 69-74), the order is raw_skull, raw_bet, raw_defaced, normalized_skull, normalized_bet, normalized_defaced. Here it's raw_bet, raw_skull, normalized_skull, raw_defaced. Consider maintaining the same order across both examples for consistency.
| # specify the output paths for the raw and normalized images | ||
| raw_bet_output_path=output_folder / "raw_bet/t1c_bet_raw.nii.gz", | ||
| raw_skull_output_path=output_folder / "raw_skull/t1c_skull_raw.nii.gz", | ||
| normalized_skull_output_path=output_folder / "normalized_skull/t1c_skull_normalized.nii.gz", |
Copilot
AI
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing normalized_bet_output_path and normalized_defaced_output_path which are present in the atlas-centric example. If these outputs are not applicable for native space preprocessing, this should be explained in a comment. Otherwise, for consistency with the atlas-centric example, these should be included.
README.md
Outdated
| # specify the output paths for the raw and normalized images | ||
| raw_bet_output_path=output_folder / "raw_bet/flair_bet_raw.nii.gz", | ||
| raw_skull_output_path=output_folder / "raw_skull/flair_skull_raw.nii.gz", | ||
| normalized_skull_output_path=output_folder / "normalized_skull/flair_skull_normalized.nii.gz", |
Copilot
AI
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing normalized_bet_output_path and normalized_defaced_output_path which are present in the atlas-centric example. If these outputs are not applicable for native space preprocessing, this should be explained in a comment. Otherwise, for consistency with the atlas-centric example, these should be included.
|
@copilot please adress review comments :) |
Co-authored-by: neuronflow <7048826+neuronflow@users.noreply.github.com>
Fixed the review comments in commit f6f8b1c:
The examples now match the structure of the actual example files in the repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@copilot in both examples we need to show all possible outputs, so with skull, bet and defaced with and without normalization mention what is optional and what are required inputs. Please also improve the general readme. |
Co-authored-by: neuronflow <7048826+neuronflow@users.noreply.github.com>
Enhanced the README in commit 1e7d8af: Comprehensive Examples:
Clear Parameter Documentation: Improved README:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Updates README to use current preprocessor classes instead of the deprecated
Preprocessorclass, and provides comprehensive documentation with all available output options clearly marked as required or optional.Changes Made
Examples Updated
PreprocessorwithAtlasCentricPreprocessorin the Usage sectionraw_bet_output_path,raw_skull_output_path,raw_defaced_output_pathnormalized_bet_output_path,normalized_skull_output_path,normalized_defaced_output_pathbet_mask_output_path,defacing_mask_output_pathDocumentation Improvements
normalized_*outputsTechnical Details
Pathobjects consistentlypreprocessor.run()calls with all save directory parameters/path/to/patient,/path/to/output)Testing
The README now provides comprehensive, user-friendly documentation that makes it easy to understand all available preprocessing options and clearly indicates what's required versus optional.
Fixes #161
Original prompt
Fixes #161
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.