Skip to content

67 feature request ants registration backend #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Mar 1, 2024
Merged

67 feature request ants registration backend #68

merged 30 commits into from
Mar 1, 2024

Conversation

@neuronflow
Copy link
Collaborator

No description provided.

neuronflow and others added 8 commits February 23, 2024 11:34
@neuronflow @IsraMekki0
initial commit
f4d0740 
Co-authored-by: Isra Mekki <IsraMekki0@users.noreply.github.com>
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
make matrix endings backend agnostic
0bc3c6c 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow @IsraMekki0
add example
b7411f6 
Co-authored-by: Isra Mekki <IsraMekki0@users.noreply.github.com>
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
fix import
e0c42ab 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
add todo for tests
b379252 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
transform
defda26 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
reg working
e3e9b35 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
add todo
b2ed6f8 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow neuronflow added the enhancement New feature or request label Feb 23, 2024
@neuronflow neuronflow linked an issue Feb 23, 2024 that may be closed by this pull request
[feature request] ANTs registration backend #67
Closed
@neuronflow neuronflow marked this pull request as draft February 23, 2024 11:22
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Feb 23, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@neuronflow
Copy link
Collaborator Author

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Feb 23, 2024

🤖 I will now format your code with black. Check the status here.

brainless-bot bot and others added 4 commits February 23, 2024 11:32
@brainless-bot
Autoformat with black
a3ba11d
@neuronflow
docstring
93eb06e 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
kwargs
de82e99 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
nicer
a94b321 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Feb 23, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@neuronflow
bump version requirements
a022cd8 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
Copy link
Collaborator Author

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Feb 23, 2024

🤖 I will now format your code with black. Check the status here.

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Feb 23, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@neuronflow
Copy link
Collaborator Author

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Feb 27, 2024

🤖 I will now format your code with black. Check the status here.

@neuronflow neuronflow marked this pull request as ready for review February 27, 2024 17:05
@neuronflow neuronflow marked this pull request as draft February 27, 2024 17:05
neuronflow
neuronflow commented Feb 27, 2024
View reviewed changes
@neuronflow
add comment
d050a40 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
Copy link
Collaborator Author

@IsraMekki0 okay, now it fails because ANTs is not installed :)

neuronflow and others added 8 commits February 27, 2024 18:20
@neuronflow
clean
8060dcc 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@IsraMekki0
Make ants an optional dependency
d2e2227
@IsraMekki0
Modify warning to install ants via brainles
cb92dbe
@neuronflow
introduce all
197c02b 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow @IsraMekki0
add comments so we understand our own code :)
06e627b 
Co-authored-by: Isra Mekki <IsraMekki0@users.noreply.github.com>
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
clean
66eb52e 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
introduce tests for ANTs
13036c4 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
registrator tests
d0ad94d 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Mar 1, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@neuronflow
basic logging
7ce7a04 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
create matrixes for transform tests
36750eb 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
logging
c2cef50 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
registration and transformation tests
8fadd54 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow
working tests
45f2458 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow neuronflow marked this pull request as ready for review March 1, 2024 10:50
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Mar 1, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@neuronflow
Copy link
Collaborator Author

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Mar 1, 2024

🤖 I will now format your code with black. Check the status here.

brainless-bot bot and others added 2 commits March 1, 2024 10:51
@brainless-bot
Autoformat with black
df8dca2
@neuronflow
change tests to contain all dependencies
d7731e8 
Signed-off-by: neuronflow <florian.kofler@tum.de>
@neuronflow neuronflow enabled auto-merge March 1, 2024 11:00
@neuronflow neuronflow mentioned this pull request Mar 1, 2024
Closed
2 tasks
@neuronflow neuronflow linked an issue Mar 1, 2024 that may be closed by this pull request
The pipeline doesn't run on MacOs #3
Closed
2 tasks
@neuronflow neuronflow merged commit bd75325 into main Mar 1, 2024
@neuronflow neuronflow deleted the 67-feature-request-ants-registration-backend branch March 1, 2024 11:02
@neuronflow
Copy link
Collaborator Author

see for replicating the BTK ANTs preprocessing:
ANTsX/ANTsPy#553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@neuronflow neuronflow

@IsraMekki0 IsraMekki0

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feature request] ANTs registration backend The pipeline doesn't run on MacOs

3 participants

@neuronflow @IsraMekki0