Skip to content

Conversation

evamariie
Copy link
Collaborator

  • notebook: added picture, some cells with Markdown/description and path descriptions
  • changed path name for easy usage in notebook and colab
  • updated/added visualizations in
    a) notebook (tumor visible in example slices + sequence as title)
    b) utils (function: visualize_data2)
  • runs in linus (no errors)

@neuronflow
Copy link
Contributor

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Mar 6, 2024

🤖 I will now format your code with black. Check the status here.

@neuronflow
Copy link
Contributor

@MarcelRosier our formatting fails, there's a node error msg. Can you have a look please?

@MarcelRosier
Copy link
Collaborator

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Mar 7, 2024

🤖 I will now format your code with black. Check the status here.

@MarcelRosier
Copy link
Collaborator

MarcelRosier commented Mar 7, 2024

fixed node version, but that wasnt the issue.
I think the format action fails because the PR isnt from a branch but from a fork and the action does not have permission to checkout the fork afterbeing triggered by a comment. not sure if this can be easily resolved. in the meantime either fix the formatting issue locally:

$ pip install black
$ black .

or use a regular branch instead of a fork @neuronflow @evamariie

@neuronflow
Copy link
Contributor

neuronflow commented Mar 7, 2024

Thanks for looking into it @MarcelRosier !

@evamariie please install black and format your code (do this for all PRs). You will probably need the Jupyter version of black. I will add you as a developer for this repo, so you don't need to fork in the future and can enjoy the brainless bot :)

@MarcelRosier
Copy link
Collaborator

MarcelRosier commented Mar 10, 2024

ok the lint action will also not work properly for forks since it depends on env secrets that can not be accessed in PRs from a fork.

@neuronflow neuronflow marked this pull request as ready for review March 13, 2024 08:10
@neuronflow neuronflow merged commit ee7fd3a into BrainLesion:main Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants