-
Notifications
You must be signed in to change notification settings - Fork 87
Added compatibility with Symfony 4 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @novecode. Thanks for the contribution. Can you explain why you made this change? |
|
Hi, I decided to do this PR because it was impossible to require composer-git-hooks in projects that were already using symfony/console v4.0. |
|
Okay, fair enough. what of removing |
|
symfony/console ^4.0 requires php ^7.1. It's why Travis build was failing: Perhaps best solution would be change .travis.yml to something like this: |
|
Okay, can you do that instead? |
|
Yes, I have done it in this commit: https://github.com/BrainMaestro/composer-git-hooks/pull/12/commits/32d67af44fbe6cb952dfc59b76dc8a25b032bca7 Travis will check now PHP 5.6, 7.0 and 7.1 versions. I have added a composer.json validation too. |
|
I don't think this project is compatible with PHP 5.6. It has PHP 7 only features. Also, the travis build isn't being triggered for some reason |
|
@novecode thanks |
No description provided.