Prevent localize returning undefined + cleanup#57
Merged
Conversation
bearfriend
force-pushed
the
dgleckler/no-undefined
branch
from
201dd8b to
d5a0ae9
Compare
bearfriend
commented
Mar 28, 2024
| args[arguments[i]] = arguments[i + 1]; | ||
| } | ||
|
|
||
| const replacements = args.reduce((acc, a, idx) => idx % 2 ? acc : { ...acc, [a]: args[idx + 1] }, {}); |
Contributor
Author
There was a problem hiding this comment.
Not opposed to putting this back to a for if this is too unreadable. I just like things like this being isolated as much as possible.
|
🎉 This PR is included in version 2.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
localizecan returnundefinedif theresourcesare not ready yet, which can throw errors if consumers always expect a string.Also eliminated
argumentsandbind.