Feat/profiles retained locally #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysonthomas9
requested review from
Copilot
and removed request for
tysonthomas9
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for persistent Chromium data storage to enable retaining browser profiles locally across container restarts. The changes configure a volume mount system that allows Chromium user data, profiles, and cache to persist on the host filesystem.
Key changes:
- Adds configurable Chromium data persistence through
CHROMIUM_DATA_HOSTenvironment variable - Removes hardcoded
--user-data-dirfrom Chromium flags to allow dynamic configuration - Updates Docker configuration to support optional volume mounting for browser data
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| run-local.sh | Implements volume mounting logic for persistent Chromium data and removes hardcoded user data directory |
| docker-compose.yml | Updates image tag and adds optional volume mount for Chromium data persistence |
| Makefile | Adds help documentation and environment variable support for data persistence |
| Dockerfile.local | Creates /data directory structure and declares volume for Chromium data mounting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
run-local.sh
Outdated
|
|
||
| # Add Chromium data volume if specified | ||
| if [[ -n "$CHROMIUM_DATA_VOLUME" ]]; then | ||
| RUN_ARGS+=( $CHROMIUM_DATA_VOLUME ) |
There was a problem hiding this comment.
The variable $CHROMIUM_DATA_VOLUME should be quoted to prevent word splitting. Change to \"$CHROMIUM_DATA_VOLUME\".
Suggested change
| RUN_ARGS+=( $CHROMIUM_DATA_VOLUME ) | |
| RUN_ARGS+=( "$CHROMIUM_DATA_VOLUME" ) |
run-local.sh
Outdated
| # Local-friendly Chrome flags (less restrictive than cloud) + custom DevTools frontend | ||
| export CHROMIUM_FLAGS="--user-data-dir=/home/kernel/user-data --disable-dev-shm-usage --start-maximized --remote-allow-origins=* --no-sandbox --disable-setuid-sandbox --custom-devtools-frontend=http://localhost:8001/" | ||
| # Note: --user-data-dir will be set automatically by start-chromium.sh using CHROMIUM_DATA_DIR | ||
| export CHROMIUM_FLAGS="--disable-dev-shm-usage --start-maximized --remote-allow-origins=* --no-sandbox --disable-setuid-sandbox --custom-devtools-frontend=http://localhost:8001/" |
Contributor
There was a problem hiding this comment.
Should we change this? because it will create security issue if we allow these.
- ✅ Chrome version and all 41 profile files persist across restarts - ✅ Can customize location with CHROMIUM_DATA_HOST - ✅ Can disable with CHROMIUM_DATA_HOST="" - ✅ Docker-compose works with env var or default
Contributor
tysonthomas9
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.