Skip to content

Add authentication Apis#64

Merged
fredfalcon merged 4 commits intoOWASP-BLT:mainfrom
ankit2001:add_authentication
Jun 29, 2021
Merged

Add authentication Apis#64
fredfalcon merged 4 commits intoOWASP-BLT:mainfrom
ankit2001:add_authentication

Conversation

@ankit2001
Copy link
Copy Markdown
Contributor

This is an in progress PR for adding all authentication APIs in the frontend.
Currently working on it.

Copy link
Copy Markdown

@fredfalcon fredfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix these:

$ flutter "analyze"
Downloading Material fonts... 722ms
Downloading Gradle Wrapper... 16ms
Downloading package sky_engine... 149ms
Downloading flutter_patched_sdk tools... 361ms
Downloading flutter_patched_sdk_product tools... 339ms
Downloading darwin-x64 tools... 2,921ms
Downloading libimobiledevice... 26ms
Downloading usbmuxd... 13ms
Downloading libplist... 12ms
Downloading openssl... 189ms
Downloading ios-deploy... 13ms
Downloading darwin-x64/font-subset tools... 266ms
Running "flutter pub get" in git... 16.5s
Analyzing git...
error • 3 positional argument(s) expected, but 2 found • lib/pages/login.dart:74:23 • not_enough_positional_arguments
error • The body might complete normally, causing 'null' to be returned, but the return type is a potentially non-nullable type • lib/providers/auth.dart:130:12 • body_might_complete_normally
info • The value of the local variable 'response' isn't used • lib/providers/auth.dart:134:14 • unused_local_variable
error • The await expression can only be used in an async function • lib/providers/auth.dart:134:25 • await_in_wrong_context
info • Name non-constant identifiers using lowerCamelCase • lib/providers/auth.dart:165:16 • non_constant_identifier_names
error • The method 'get' isn't defined for the type 'Response' • lib/providers/auth.dart:168:22 • undefined_method
6 issues found. (ran in 21.8s)
flutter analyze found errors: exit status 1

@ankit2001 ankit2001 force-pushed the add_authentication branch from 7ff7c7f to 29183fd Compare June 23, 2021 08:31
@ankit2001
Copy link
Copy Markdown
Contributor Author

Can you please fix these:

$ flutter "analyze"
Downloading Material fonts... 722ms
Downloading Gradle Wrapper... 16ms
Downloading package sky_engine... 149ms
Downloading flutter_patched_sdk tools... 361ms
Downloading flutter_patched_sdk_product tools... 339ms
Downloading darwin-x64 tools... 2,921ms
Downloading libimobiledevice... 26ms
Downloading usbmuxd... 13ms
Downloading libplist... 12ms
Downloading openssl... 189ms
Downloading ios-deploy... 13ms
Downloading darwin-x64/font-subset tools... 266ms
Running "flutter pub get" in git... 16.5s
Analyzing git...
error • 3 positional argument(s) expected, but 2 found • lib/pages/login.dart:74:23 • not_enough_positional_arguments
error • The body might complete normally, causing 'null' to be returned, but the return type is a potentially non-nullable type • lib/providers/auth.dart:130:12 • body_might_complete_normally
info • The value of the local variable 'response' isn't used • lib/providers/auth.dart:134:14 • unused_local_variable
error • The await expression can only be used in an async function • lib/providers/auth.dart:134:25 • await_in_wrong_context
info • Name non-constant identifiers using lowerCamelCase • lib/providers/auth.dart:165:16 • non_constant_identifier_names
error • The method 'get' isn't defined for the type 'Response' • lib/providers/auth.dart:168:22 • undefined_method
6 issues found. (ran in 21.8s)
flutter analyze found errors: exit status

I fixed this

@ankit2001 ankit2001 closed this Jun 23, 2021
@ankit2001 ankit2001 reopened this Jun 23, 2021
@ankit2001
Copy link
Copy Markdown
Contributor Author

@fredfalcon, Login API call is successfully working now, I have logged in through the App using the localhost endpoints.

@ankit2001 ankit2001 requested a review from fredfalcon June 23, 2021 16:58
Copy link
Copy Markdown

@fredfalcon fredfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update to staging https://bugheist-staging.herokuapp.com/

@ankit2001 ankit2001 requested a review from fredfalcon June 24, 2021 07:03
DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants