Closed
Conversation
|
The page looks good, but we don't need all of the extra connectivity plugins can you please remove those? |
fredfalcon
suggested changes
Mar 13, 2022
fredfalcon
left a comment
fredfalcon
left a comment
There was a problem hiding this comment.
please remove connectivity plugins and just have a simple error page
Contributor
Author
|
@fredfalcon , where we will use this error page then. Can you please tell me its usecase? |
|
I was originally thinking it would be when there was an error in the app but we can have a toast for that. Maybe this can be the page that happens after a bug is submitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add an error page in the App and fix OWASP-BLT/BLT#3594.
Please review it @fredfalcon, @souravbadami.
Thanks.