Fix connection leak #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for better resource management Fixes #35.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a connection leak in the API utility class by properly closing OkHttp Response objects using try-with-resources blocks. The changes ensure that HTTP connections are properly released after use, preventing resource exhaustion over time.
Key Changes:
- Wrapped all Response objects in async methods with try-with-resources to ensure proper connection cleanup
- Added @NotNull annotations to Callback method parameters for better null-safety
- Made the httpClient field final to prevent accidental reassignment
- Replaced printStackTrace() calls with structured logging using ComponentLogger
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35.