chore: migrate api to modular arc #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Data Dragon Service - Busca dados estáticos da Riot 2. Região Configurável - Não mais hardcoded, usa player.region 3. Champion Mapping - Funcionando corretamente agora 4. 8 Novos API Endpoints - Para dados da Riot 5. 5 Rake Tasks - Gerenciamento de cache e sync 6. Suite de Testes - Criada para SyncPlayerFromRiotJob
- Create Players::Services::RiotSyncService - Extract Riot API logic from controller - Support import, sync, search operations - Add retry logic for better success
- Create Players::Services::StatsService (90 lines) - Extract statistics calculation - Calculate win rate, KDA, recent form - Make stats reusable and testable
- Move to Players::Controllers namespace - Reduce from 750 to 350 lines (-53%) - Use services for business logic - Create proxy for backwards compatibility
- Move serializers to Players module - Move jobs to Players module - Organize all players domain code
- Move AuthController to module - Move User and Organization serializers - JwtService already in module - Create proxy controller
- Migrate 3 core business modules - Organize by domain functionality - Create proxies for all
- Migrate 7 analytics controllers - Organize performance analysis - Maintain namespace structure
- Migrate scouting controllers - Move serializers and jobs - Organize talent discovery
- Migrate 2 Riot controllers - Move 2 services to module - Consolidate Riot API functionality
- Migrate VOD Reviews (2 controllers) - Migrate Dashboard module - Organize video review features
- Migrate Dashboard module
Contributor
🔒 Brakeman Security Scan
✅ No high confidence issues found. |
Contributor
📦 Dependency Security Check✅ No known vulnerabilities found. View Report |
Contributor
🔍 Semgrep Static Analysis
|
Contributor
🔐 Security Scan Summary
✅ All security checks passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.