Skip to content

Add stop scripts on error #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2021
Merged

Add stop scripts on error #161

merged 1 commit into from
Jul 30, 2021

Conversation

@numbnp
Copy link
Contributor

@numbnp numbnp commented Jun 12, 2021 •
edited
Loading

Add "set -e" in all bash scripts, for exit on error

Resolve for #160

@numbnp numbnp mentioned this pull request Jun 12, 2021
Closed
3zrv
3zrv approved these changes Jun 24, 2021
View reviewed changes
Copy link

@3zrv 3zrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Buuntu Buuntu merged commit 0d4b4ee into Buuntu:master Jul 30, 2021
@Buuntu
Copy link
Owner

Buuntu commented Jul 30, 2021

Thanks for doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@3zrv 3zrv 3zrv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@numbnp @Buuntu @3zrv