Skip to content

Conversation

@stramel
Copy link
Collaborator

@stramel stramel commented Mar 22, 2021

Closes #28

Defaults the column.sort to byTextAscending and inverts the result for descending sorts.

Copy link
Owner

@Buuntu Buuntu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! Do you mind adding a quick test case that covers the bug/case you found in #28? And using Angular commit convention so the version is automatically bumped? See https://github.com/Buuntu/react-final-table/blob/master/CONTRIBUTING.md

@stramel
Copy link
Collaborator Author

stramel commented Mar 27, 2021

I don't think there is a bug to really cover in #28. Just improvements with the performance and code size reduction.

@stramel stramel force-pushed the ms/improve-sort-logic branch from 16082ad to fb8d9cf Compare March 27, 2021 03:24
@codecov-io
Copy link

Codecov Report

Merging #29 (fb8d9cf) into master (250a068) will increase coverage by 1.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   97.70%   99.05%   +1.34%     
==========================================
  Files           4        4              
  Lines         218      211       -7     
  Branches       49       44       -5     
==========================================
- Hits          213      209       -4     
+ Misses          5        2       -3     
Impacted Files Coverage Δ
src/hooks.tsx 98.85% <100.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250a068...fb8d9cf. Read the comment docs.

@Buuntu
Copy link
Owner

Buuntu commented Mar 27, 2021

I don't think there is a bug to really cover in #28. Just improvements with the performance and code size reduction.

That's true, okay looks good to me!

@Buuntu Buuntu merged commit a983e9c into Buuntu:master Mar 27, 2021
@stramel stramel deleted the ms/improve-sort-logic branch March 27, 2021 03:27
@github-actions
Copy link

🎉 This PR is included in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sorting Improvements

3 participants