Merged
Conversation
Byron
force-pushed
the
fix-v1-negotiation
branch
2 times, most recently
from
0cf0821 to
af64b80
Compare
The logic previously tried to estimate when a pack can be expected, and when a NAK is the end of a block, or the beginning of a pack. This can be known because a pack (with our settings) needs two things: * the server thinks it's ready * a `done` sent by the client If the server doesn't think it's ready it will send NAK and be done. So the logic should be, for a NAK to stop the read-loop, that the client expects a pack, and the server is ready. If the client is not ready, or the server isn't ready, keep NAK and consider them the end of a round, hence break the loop.
Byron
force-pushed
the
fix-v1-negotiation
branch
from
af64b80 to
6295dec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1061
The logic previously tried to estimate when a pack can be expected,
and when a NAK is the end of a block, or the beginning of a pack.
This can be known because a pack (with our settings) needs two things:
donesent by the clientIf the server doesn't think it's ready it will send NAK and be done.
So the logic should be, for a NAK to stop the read-loop, that the client
expects a pack, and the server is ready. If the client is not ready, or
the server isn't ready, keep NAK and consider them the end of a round,
hence break the loop.