Skip to content

Allow for errors in initial window #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Allow for errors in initial window #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
225af92
feat: allow for errors in initial window
AlexanderGrooff Sep 19, 2022
5a9e590
typo: excepted -> expected
AlexanderGrooff Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Ephemeral/EphemeralHypernodeManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ public function waitForAvailability(string $ephemeralHypernode, int $timeout = 9
$latest = microtime(true);
$timeElapsed = 0;
$resolved = false;
$interval = 3;
$allowedErrorWindow = 3;

while ($timeElapsed < $timeout && !$resolved) {
$now = microtime(true);
Expand All @@ -76,10 +78,19 @@ public function waitForAvailability(string $ephemeralHypernode, int $timeout = 9
// Otherwise, there's an error, and it should be propagated.
if ($e->getCode() !== 404) {
throw $e;
} elseif ($timeElapsed < $allowedErrorWindow) {
// Sometimes we get an error where the logbook is not yet available, but it will be soon.
// We allow a small window for this to happen, and then we throw an exception.
sprintf(
'Got an expected exception during the allowed error window of HTTP code %d, waiting for %s to become available',
$e->getCode(),
$ephemeralHypernode
);
continue;
}
}

sleep(5);
sleep($interval);
}

if (!$resolved) {
Expand Down