Skip to content

Ensure .hypernode exists #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2022
Merged

Ensure .hypernode exists #67

merged 1 commit into from
Dec 8, 2022

Conversation

AlexanderGrooff
Copy link
Contributor

Fixes issues where Nginx tries to rsync to the .hypernode/nginx dir

tdgroot
tdgroot reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@tdgroot tdgroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be done for everything in .hypernode? Perhaps it owuld be better to have a dothypernode release path which does this and let the subdirectories rely on that variable

@AlexanderGrooff
fix: ensure .hypernode/nginx or supervisor exists
36b0391 
This is done for Varnish but not for Nginx/Supervisor
tdgroot
tdgroot approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@tdgroot tdgroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@AlexanderGrooff AlexanderGrooff merged commit 39e6b2f into master Dec 8, 2022
@AlexanderGrooff AlexanderGrooff deleted the ensure-hypernode-dir branch December 8, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdgroot tdgroot tdgroot approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexanderGrooff @tdgroot