drivers: Flash: Add SPI NAND Flash driver support #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SPI NAND Flash driver support Signed-off-by: Daniel Zhang <danielzhang@mxic.com.cn>
Every commit in nrfconnect has to start with a tag like [nrf mergeup], [nrf fromtree], [nrf fromlist], [nrf noup]. This is absolutely irrelevant to us.
|
It compiles when added to the DT, so we can merge for now. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds SPI NAND Flash driver support by introducing a comprehensive driver implementation with optional software ECC support using BCH (Bose-Chaudhuri-Hocquenghem) error correction algorithms.
- Complete SPI NAND flash driver with read, write, and erase operations
- Optional software-based ECC support with BCH algorithm implementation
- Device tree binding and configuration support for SPI NAND devices
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
dts/bindings/mtd/jedec,spi-nand.yaml |
Device tree binding definition for SPI NAND flash devices |
drivers/flash/spi_nand.h |
Header file with SPI NAND constants, opcodes, and register definitions |
drivers/flash/spi_nand.c |
Main SPI NAND driver implementation with read/write/erase operations |
drivers/flash/bch.h |
BCH error correction header with data structures and function declarations |
drivers/flash/bch.c |
BCH error correction algorithm implementation |
drivers/flash/Kconfig.nand |
Kconfig options for SPI NAND driver configuration |
drivers/flash/Kconfig |
Updated to include SPI NAND configuration |
drivers/flash/CMakeLists.txt |
Build system integration for SPI NAND driver files |
.github/workflows/commit-tags.yml |
Removed entire GitHub workflow file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
These suggestions will also be sent upstream. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
arnout
reviewed
Sep 23, 2025
arnout
approved these changes
Sep 23, 2025
Co-authored-by: Arnout Vandecappelle <arnout@rnout.be>
embed
commented
Sep 23, 2025
embed
commented
Sep 23, 2025
embed
commented
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SPI NAND Flash driver support
cherry-picked hash zephyrproject-rtos@84f8da1, the PR zephyrproject-rtos#50690 as of 2025-09-22