Skip to content

Fix for #319 #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Fix for #319 #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions History.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# v4.0.3

* [FIXED] Issue where invalid rows were not accounted for when skipRows was set [#317](https://github.com/C2FO/fast-csv/issues/317)
* [FIXED] Issue where readableObjectMode was not set to false when formatting [#319](https://github.com/C2FO/fast-csv/issues/319)

# v4.0.2

Expand Down
2 changes: 1 addition & 1 deletion packages/format/src/CsvFormatterStream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export class CsvFormatterStream<I extends Row, O extends Row> extends Transform
private hasWrittenBOM = false;

public constructor(formatterOptions: FormatterOptions<I, O>) {
super({ objectMode: formatterOptions.objectMode });
super({ writableObjectMode: formatterOptions.objectMode });
this.formatterOptions = formatterOptions;
this.rowFormatter = new RowFormatter(formatterOptions);
// if writeBOM is false then set to true
Expand Down