Skip to content

Conversation

@lselden
Copy link

@lselden lselden commented Jul 21, 2020

@types/node is getting installed as a dependency, which isn't necessary, and ends up adding extra 700kb to install size.

I'm assuming this is just an oversight. I didn't create tests because there's no direct references to the types, and I can't imagine how this change would break things. It works for me locally after deleting it from node_modules

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@types/node is getting installed as a dependency, which isn't necessary, and ends up adding extra 700kb to install size
@coveralls
Copy link

coveralls commented Jul 21, 2020

Pull Request Test Coverage Report for Build 177649217

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.986%

Totals Coverage Status
Change from base Build 174253821: 0.0%
Covered Lines: 729
Relevant Lines: 745

💛 - Coveralls

@doug-martin
Copy link
Contributor

@lselden the @types/node is required because it is used in a few places for example:

Both of those declarations are part of the released packages in the defintion files so it is a required dependency, otherwise anytime you installed the package you would also have to install the @types/node package. There is a lot of questions around this see the following as a few examples:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants