Make @types/node a dev dependency #433
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@types/node is getting installed as a dependency, which isn't necessary, and ends up adding extra 700kb to install size.
I'm assuming this is just an oversight. I didn't create tests because there's no direct references to the types, and I can't imagine how this change would break things. It works for me locally after deleting it from node_modules
All Submissions:
Changes to Core Features: