fix: hide filter and action buttons on tablet screens to prevent UI o… #257
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Hell1213
force-pushed
the
fix/tablet-ui-breakage-issue-221
branch
2 times, most recently
from
0478f39 to
e2a7440
Compare
Hell1213
left a comment
Hell1213
left a comment
There was a problem hiding this comment.
It looks good to me nothing breaked and now md screens show mobile viewport
|
@its-me-abhishek Ready for review! Tablet screens now use BottomBar like mobile. |
| icon={<Key lable="t" />} | ||
| /> | ||
| <div className="pr-2"> | ||
| <div className="pr-2 hidden lg:block"> |
There was a problem hiding this comment.
this also hides the add task button
There was a problem hiding this comment.
add task button will no more hidden
| /> | ||
| </div> | ||
| <div className="hidden sm:flex flex-col items-end gap-2"> | ||
| <div className="hidden lg:flex flex-col items-end gap-2"> |
There was a problem hiding this comment.
this hides the add sync button
There was a problem hiding this comment.
resolved also for sync button no more hidden from now
thanks I'm on it , will update the pr soon as requested ! |
…verflow Changed responsive breakpoints from sm: to lg: for filter buttons, Add Task, and Sync buttons. BottomBar now shows on tablets (640px-1024px) like mobile devices. Fixes CCExtractor#221
Hell1213
force-pushed
the
fix/tablet-ui-breakage-issue-221
branch
from
e2a7440 to
5a01c6f
Compare
|
@its-me-abhishek updated the pr accordingly as requested ! |
2 participants
Fixed UI breakage on tablet screens (iPad/Surface) where filter and action buttons were overflowing outside the container. Changed responsive breakpoints from
sm:(640px) tolg:(1024px) for filter buttons, Add Task, and Sync buttons. BottomBar now shows on tablets (640px-1024px) like mobile devices, providing a clean mobile-friendly experience.Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
Changes Made:
BottomBar.tsx: Changedsm:hiddentolg:hiddento show BottomBar on tabletsTasks.tsx: Changed filter buttons (Projects, Status, Tags) fromsm:flexScreenshots
