Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Oct 10, 2025

  • Create docs/_includes/default_mission_impact_values.md with the tip content
  • Replace the inline tip in docs/howto/bootstrap/collect.md with the include statement
  • Add the include to docs/reference/decision_points/mission_impact.md
  • Add the include to docs/howto/gathering_info/mission_impact.md
  • Fix link paths to use absolute URLs (starting with /) to work correctly when included from different locations
Original prompt

This section details on the original issue you should resolve

<issue_title>Refactor default mission impact values in collect.md into an includable</issue_title>
<issue_description>Child of #522

  • Refactor the Default Mission Impact Values tip from docs/howto/bootstrap/collect.md into an includable file in docs/_includes
  • Replace the tip in collect.md with the included tip
  • Include the tip to the decision point reference page docs/reference/decision_points/mission_impact.md
  • Include the tip in the "gathering info" page for mission impact
    </issue_description>

<agent_instructions>This is very similar to the changes in PR #1010, follow those as an example.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes #964


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: ahouseholder <2594236+ahouseholder@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Refactor default mission impact values into includable file Refactor Default Mission Impact Values into reusable include file Oct 10, 2025
Copilot finished work on behalf of ahouseholder October 10, 2025 20:41
@Copilot Copilot AI requested a review from ahouseholder October 10, 2025 20:41
@ahouseholder ahouseholder marked this pull request as ready for review October 14, 2025 16:40
@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 16:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors the "Default Mission Impact Values" tip from the bootstrap guide into a reusable include file to eliminate duplication and improve discoverability across the documentation.

  • Created a shared include file for the Default Mission Impact Values tip
  • Replaced inline content in the bootstrap guide with an include statement
  • Added the tip to the Mission Impact decision point reference and gathering info pages

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
docs/_includes/default_mission_impact_values.md New include file containing the Default Mission Impact Values tip
docs/howto/bootstrap/collect.md Replaced inline tip with include statement
docs/reference/decision_points/mission_impact.md Added include for the tip after the gathering info section
docs/howto/gathering_info/mission_impact.md Added include for the tip at the end of the document

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ahouseholder ahouseholder added the content/representation Formatting, page layout, syntax, etc. label Oct 14, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ahouseholder
Copy link
Contributor

@copilot link checker reports:

URL        `../../../reference/decision_points/mission_impact.md'
Name       `Mission Impact'
Parent URL file:///home/runner/work/SSVC/SSVC/site/howto/bootstrap/collect/index.html, line 4696, col 20
Real URL   file:///home/runner/work/SSVC/SSVC/site/reference/decision_points/mission_impact.md
Check time 0.000 seconds
Result     Error: URLError: <urlopen error [Errno 2] No such file or directory: '/home/runner/work/SSVC/SSVC/site/reference/decision_points/mission_impact.md'>

Note that we include these includable from various locations within the site, so we need a solution for included files that allows us to resolve included links no matter where the including file lives.

Co-authored-by: ahouseholder <2594236+ahouseholder@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Oct 14, 2025

@copilot link checker reports:

...

Fixed in commit a9c6f3a. Changed the links in the include file to use absolute paths (/reference/...) instead of relative paths (../../reference/...). This ensures the links resolve correctly when the include is used from different locations in the documentation.

Copilot finished work on behalf of ahouseholder October 14, 2025 17:26
@ahouseholder ahouseholder changed the base branch from main to copilot/refactor-default-exploitation-values October 14, 2025 18:12
@ahouseholder ahouseholder merged commit c5a78d9 into copilot/refactor-default-exploitation-values Oct 14, 2025
7 checks passed
@ahouseholder ahouseholder deleted the copilot/refactor-default-mission-impact branch October 14, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content/representation Formatting, page layout, syntax, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor default mission impact values in collect.md into an includable

3 participants