-
Notifications
You must be signed in to change notification settings - Fork 42
Integrate javascript #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate javascript #992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the SSVC Explorer tool by renaming it from "Policy Explorer" to "SSVC Explorer" for clearer terminology, and migrates JavaScript functionality from iframe-based architecture to a module pattern using JavaScript IIFE (Immediately Invoked Function Expression). The changes improve consistency in naming and modernize the JavaScript implementation approach.
Key changes:
- Renamed "Policy Explorer" to "SSVC Explorer" throughout documentation and navigation
- Replaced iframe-based implementation with inline HTML and JavaScript modules
- Added external JavaScript dependencies (jQuery and D3.js) for enhanced functionality
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mkdocs.yml | Updates navigation title, removes unused documentation sections, and adds JavaScript dependencies |
| docs/tutorials/starting_points.md | Updates references from "SSVC Policy Explorer" to "SSVC Explorer" |
| docs/ssvc-explorer/index.md | Replaces iframe implementation with inline HTML form and popup interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ahouseholder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's an inadvertent deletion in mkdocs.yml beyond the intended changes. Once that's corrected the rest of the PR seems fine to me.
This PR has a few changes related to Explorer.
Policy ExplorertoExplorerfor consistency and better term usage that is less confusing or heavy