Skip to content

Conversation

@CESARDELATORRE
Copy link
Owner

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements documentation for an Orchestrator Agent MCP Server feature that coordinates between Semantic Kernel's ChatCompletionAgent and the KB MCP Server for question-answering capabilities.

  • Adds comprehensive implementation plan for orchestrator agent with security-first configuration approach
  • Documents 10-step implementation process covering Azure OpenAI integration, MCP client setup, and testing
  • Updates memory.md to track the new implementation plan document

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
docs/memory.md Adds reference entry for the orchestrator agent implementation plan
docs/implementation-plans/feature-implementation-plan-orchestrator-agent.md Complete implementation plan with 10 steps covering project setup, security configuration, MCP integration, and testing

Comment on lines +107 to +108
string kbMcpServerPath = Path.GetFullPath(Path.Combine(
AppContext.BaseDirectory, "../../../../mcp-server-kb-content-fetcher/bin/Debug/net9.0/mcp-server-kb-content-fetcher.exe"));
Copy link

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded relative path is fragile and will break if the project structure changes or when running from different locations. Consider making this configurable through appsettings.json or user secrets, or use a more robust path resolution mechanism.

Suggested change
string kbMcpServerPath = Path.GetFullPath(Path.Combine(
AppContext.BaseDirectory, "../../../../mcp-server-kb-content-fetcher/bin/Debug/net9.0/mcp-server-kb-content-fetcher.exe"));
// Get the KB MCP server executable path from configuration (e.g., appsettings.json or user secrets)
string? kbMcpServerPath = config["KbMcpServer:ExecutablePath"];
if (string.IsNullOrWhiteSpace(kbMcpServerPath) || !File.Exists(kbMcpServerPath))
{
throw new FileNotFoundException("KB MCP server executable path is not configured or does not exist. Please set 'KbMcpServer:ExecutablePath' in your configuration.");
}

Copilot uses AI. Check for mistakes.
CESARDELATORRE and others added 2 commits September 14, 2025 15:50
…ator-agent.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ator-agent.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants